Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script/check-config.sh: add SELinux and AppArmor #2874

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

KentaTada
Copy link
Contributor

SELinux and AppArmor are always enabled since runc v1.0.0-rc93

Signed-off-by: Kenta Tada [email protected]

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK. These should go in optional features. The fact that these are always enabled does not mean these are required -- it means these are supported.

SELinux and AppArmor are always enabled since runc v1.0.0-rc93

Signed-off-by: Kenta Tada <[email protected]>
@KentaTada
Copy link
Contributor Author

Thanks a lot.
I changed these options from necessary to optional features.

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
Copy link
Contributor

CI failure is a flake (#2805); CI restarted

@kolyshkin kolyshkin closed this Mar 28, 2021
@kolyshkin kolyshkin reopened this Mar 28, 2021
@mrunalp mrunalp merged commit b79201f into opencontainers:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants