Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcontainer/integration: adjust the file mode #2839

Conversation

KentaTada
Copy link
Contributor

This commit adjusts the file mode to use the latest golang style
Related to #2625

Signed-off-by: Kenta Tada [email protected]

@kolyshkin
Copy link
Contributor

@KentaTada perhaps you can add the commit from #2838 to this PR (or vice versa), as the changes are similar and only touch _test.go files. I see no big reason in having two separate PRs for this.

@KentaTada
Copy link
Contributor Author

@KentaTada perhaps you can add the commit from #2838 to this PR (or vice versa), as the changes are similar and only touch _test.go files. I see no big reason in having two separate PRs for this.

I just want to match the grain size of commits like past commits because I think it is suitable to match to the area reviewers are good at.
If you don't mind it, I'll combine some changes into one.

@kolyshkin
Copy link
Contributor

If you don't mind it, I'll combine some changes into one.

Yes please (two distinct commits, one single PR)

This commit adjusts the file mode to use the latest golang style
Related to opencontainers#2625

Signed-off-by: Kenta Tada <[email protected]>
@KentaTada
Copy link
Contributor Author

Thanks for the reply.
I combined #2838 into this PR.

@KentaTada
Copy link
Contributor Author

@kolyshkin I combined #2838 into this PR at first.
I will combine another miscellaneous changes about this activity into one commit in the next PR.
If the next commit is a big patch, please feel free to ask me.

@kolyshkin
Copy link
Contributor

close/reopen to kick ci

@kolyshkin kolyshkin closed this Apr 21, 2021
@kolyshkin kolyshkin reopened this Apr 21, 2021
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming 🟢 CI)

@kolyshkin
Copy link
Contributor

kolyshkin commented Jun 6, 2022

Superseded by commit e604871 (PR #2975).

@kolyshkin kolyshkin closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants