libct/cgroups/systemd: don't set limits in Apply #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All cgroup managers has Apply() and Set() methods: - Apply is used to create a cgroup (and, in case of systemd, a systemd unit) and/or put a PID into the cgroup (and unit); - Set is used to set various cgroup resources and limits. The fs/fs2 cgroup manager implements the functionality as described above. The systemd v1/v2 manager deviate -- it sets *most* of cgroup limits (those that can be projected to systemd unit properties) in Apply(), and then again *all* cgroup limits in Set (first indirectly via systemd properties -- same as in Apply, then via cgroupfs). This commit removes setting the cgroup limits from Apply, so now the systemd manager behaves the same way as the fs manager. Signed-off-by: Kir Kolyshkin <[email protected]>
|
I wanted to fix it half a year ago but did not quite understand the purpose of Apply and Set at the time. |
odinuge
approved these changes
Feb 22, 2021
|
@AkihiroSuda I would not call this a refactor -- this is a bug fix (#2813), although I agree the bug is kinda subtle. |
dqminh
approved these changes
Feb 23, 2021
mrunalp
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All cgroup managers has Apply() and Set() methods:
Apply is used to create a cgroup (and, in case of systemd,
a systemd unit) and/or put a PID into the cgroup (and unit);
Set is used to set various cgroup resources and limits.
The fs/fs2 cgroup manager implements the functionality as described above.
The systemd v1/v2 manager deviate -- it sets most of cgroup limits
(those that can be projected to systemd unit properties) in Apply(),
and then again all cgroup limits in Set (first indirectly via systemd
properties -- same as in Apply, then via cgroupfs).
This commit removes setting the cgroup limits from Apply,
so now the systemd manager behaves the same way as the fs manager.
Fixes: #2813