libct/checkProcMounts: optimize #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9c1242e ("Add white list for bind mount chec", Jan 6 2016) added a set of entries under /proc which we allow to be mounted to, for the benefit of lxcfs-like fuse-backed hack to have container's own version of /proc/meminfo etc. For some reason, the allow list check is performed at the very beginning of the function, which is not optimal. Move the check to the end -- at this point in the code we already know we're under /proc, so it make sense to consult the allow list. This makes the code slightly more logical and hopefully slightly faster. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
check-proc-opt
branch
from
bc5d515
to
692fab0
Compare
|
rebased (for new CI) |
|
CI failure is a flake (#2425), restarted. |
|
This one is easy to review in fact -- it just moves a block of code around. |
mrunalp
approved these changes
Jan 28, 2021
AkihiroSuda
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9c1242e ("Add white list for bind mount chec", Jan 6 2016)
added a set of entries under /proc which we allow to be mounted to,
for the benefit of lxcfs-like fuse-backed hack to have container's
own version of /proc/meminfo etc.
For some reason, the allow list check is performed at the very
beginning of the function, which is not optimal.
Move the check to the end -- at this point in the code we already
know we're under /proc, so it make sense to consult the allow list.
This makes the code slightly more logical and hopefully slightly faster.