fix some linting issues #2628
Merged
fix some linting issues #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Oct 2, 2020
| @@ -277,6 +277,7 @@ func RemovePaths(paths map[string]string) (err error) { | |||
| } | |||
| } | |||
| if len(paths) == 0 { | |||
| //nolint:ineffassign // done to help garbage collecting: opencontainers/runc#2506 | |||
There was a problem hiding this comment.
Looks like it at least finds them 😂 had a typo here;
level=warning msg="[runner/nolint] Found unknown linters in //nolint directives: ineffasign"
There was a problem hiding this comment.
Can we change the function to return a separate map?
There was a problem hiding this comment.
Can we change the function to return a separate map?
I don't think this makes any sense. No caller of RemovePaths is interested in this map; it is cleaned here in place only to help garbage collector.
If you don't like it we can just drop the paths = make(map[string]string) line, but I think it makes sense to keep it.
kolyshkin
reviewed
Oct 5, 2020
AkihiroSuda
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly a test to see if golang-ci-lint picks up these changes in CI as well (not sure if the "nolint" tags work everywhere; they can be somewhat hit and miss