fixups to tests/int/checkpoint.bats #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove whitespace at EOL Signed-off-by: Kir Kolyshkin <[email protected]>
1. When using `runc`, we should check `$status` and not `$?`. 2. Before exit code check, let's (try to) show errors from CRIU log. Signed-off-by: Kir Kolyshkin <[email protected]>
Closed
|
@AkihiroSuda @mrunalp PTAL |
AkihiroSuda
reviewed
Jun 18, 2020
AkihiroSuda
approved these changes
Jun 23, 2020
mrunalp
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into #2475 I noticed there are no CRIU errors shown for runc restore. Amend the script with showing errors like in other cases.
While at it
simple_cr