libct/isPaused: don't use GetPaths from v2 code #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using GetPaths from cgroupv2 unified hierarchy code is deprecated and this function will (hopefully) be removed. Use GetUnifiedPath() for v2 case. Signed-off-by: Kir Kolyshkin <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
tedyu
reviewed
Apr 2, 2020
| // A container doesn't have a freezer cgroup | ||
| return false, nil | ||
| } | ||
| filename = "freezer.state" |
There was a problem hiding this comment.
Just curious: the filenames are different for the unified versus non-unified cases. I assume this is intentional.
There was a problem hiding this comment.
@tedyu yes, cgroups v2 have different filenames for various controllers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
GetPathsfrom cgroupv2 unified hierarchy code is deprecatedand this function will (hopefully) be removed.
Use
GetUnifiedPath()for v2 case.There are more cases like this that we still need to fix, but this one is a low hanging fruit :)