travis: update configuration #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the set of Go versions (and use 1.x to always test the latest release), as well as making the cgroupv2 tests allowable failures (the vagrant setup seems to break pretty often, causing flaky failures). Signed-off-by: Aleksa Sarai <[email protected]>
AkihiroSuda
reviewed
Feb 5, 2020
| @@ -29,6 +32,7 @@ matrix: | |||
| - ssh default sudo podman run --privileged --cgroupns=private test make localunittest | |||
| allow_failures: | |||
| - go: tip | |||
| - name: "cgroup-v2" | |||
There was a problem hiding this comment.
can we add retry code to the v2 setup script instead?
There was a problem hiding this comment.
Maybe, but the v2 tests also take the longest to run -- I'm not a huge fan of the idea of having possibly-regular >1hr test runs.
There was a problem hiding this comment.
@cyphar: I'm not a huge fan of the idea of having possibly-regular >1hr test runs.
Compared to how little the CI is exercised here, that seems like an acceptable trade-off for not breaking things...? "Acceptable failures" often quickly degenerate unless someone pays close attention to them. Wouldn't it be better to try to figure out what's causing the flakes and fixing that?
|
LGTM |
|
@mrunalp PTAL? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the set of Go versions (and use 1.x to always test the latest
release), as well as making the cgroupv2 tests allowable failures (the
vagrant setup seems to break pretty often, causing flaky failures).
Signed-off-by: Aleksa Sarai [email protected]