Fix runc ps issue #1013
Merged
Fix runc ps issue #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2016
|
LGTM |
Closed
After opencontainers#1009, we don't always set `cgroup.Paths`, so `getCgroupPath()` will return wrong cgroup path because it'll take current process's cgroup as the parent, which would be wrong when we try to find the cgroup path in `runc ps` and `runc kill`. Fix it by using `m.GetPath()` to get the true cgroup paths. Reported-by: Yang Shukui <[email protected]> Signed-off-by: Qiang Huang <[email protected]>
Fixes: opencontainers#1034 Fixes: opencontainers#1031 Signed-off-by: Qiang Huang <[email protected]>
|
I added a commit to fix update and pause issues, PTAL @crosbymichael @cyphar BTW janky didn't cache this because we use |
|
LGTM. Though, I can't reproduce the original issue (presumably because my tmux setup has everything in the same systemd slice). Are there any other manager functions that we need to replace? |
|
@cyphar Not as I can find, now |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1009, we don't always set
cgroup.Paths, sogetCgroupPath()will return wrong cgroup path becauseit'll take current process's cgroup as the parent, which
would be wrong when we try to find the cgroup path in
runc ps.Fix it by using
m.GetPath()to get the true cgrouppaths.
Also Fixes: #1034
Fixes: #1031
Reported-by: Yang Shukui [email protected]
Signed-off-by: Qiang Huang [email protected]