Use Go's new standard vendoring in 1.6+

[pkieltyka]

I also suggest https://github.com/kardianos/govendor over Godeps.

[cyphar]

Sure, that's fine. But I think we should do a subtree merge or something like that to make sure that the history of vendoring isn't lost.

[cyphar]

I just tried govendor and it doesn't appear to work properly (it doesn't look like it correctly deals with nested requirements of packages and it also doesn't clean up unused files). Currently Docker's hack/vendor.sh does a better job. I'm going to take a look at govend and some others.

[LK4D4]

@cyphar I'm pretty sure that godep and glide are best vendoring tools now(glide even can vendor docker dependencies). I hate godep workflow, but it cleans unneeded files and that's only reason I prefer it over glide.

[cyphar]

@monstermunchkin said that govend might actually work nicely here.

The reason I don't like godep is because updating dependencies to a specific version (like in hack/vendor.sh) is a huge pain. I'd prefer we take the magical shell script from Docker rather than use Godep.

[LK4D4]

Yeah, I tried govend. It's really nice.

[crosbymichael]

We are now using go 1.6 if anyone would like to do the work of porting over our vendor dependencies to the new schema.

[jessfraz]

DIBS
I'm on it right now

[marcosnils]

I think I saw a PR from @cyphar that implemented this?

sent from mobile
On Jun 10, 2016 9:04 PM, "Jess Frazelle" [email protected] wrote:

DIBS

On Fri, Jun 10, 2016 at 5:00 PM -0700, "Michael Crosby" <
[email protected]> wrote:

We are now using go 1.6 if anyone would like to do the work of porting
over our vendor dependencies to the new schema.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#728 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABgV2q020XXCIbEm8EKHRg2FyGgJHB0Mks5qKftzgaJpZM4ICFFO
.

[jessfraz]

ah yeah its https://github.com/opencontainers/runc/pull/898/files

[marcosnils]

It's from @LK4D4 actually
#898
sent from mobile
On Jun 10, 2016 9:05 PM, "Marcos Lilljedahl" [email protected] wrote:

I think I saw a PR from @cyphar that implemented this?

sent from mobile
On Jun 10, 2016 9:04 PM, "Jess Frazelle" [email protected] wrote:

DIBS

On Fri, Jun 10, 2016 at 5:00 PM -0700, "Michael Crosby" <
[email protected]> wrote:

We are now using go 1.6 if anyone would like to do the work of porting
over our vendor dependencies to the new schema.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#728 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABgV2q020XXCIbEm8EKHRg2FyGgJHB0Mks5qKftzgaJpZM4ICFFO
.

[crosbymichael]

@jfrazelle you trying to crash my browser giving me a link with /files on a PR with 18k line changes?

[jessfraz]

so I was stuck there and yeah...

[crosbymichael]

I think we resolved our vendoring issues using vndr that uses the go vendor setup