libct/cgroupv1: fix TestGetCgroupMounts test cases

When testing GetCgroupMounts, the map data is supposed to be obtained from /proc/self/cgroup, but since we're mocking things, we provide our own map. Unfortunately, not all controllers existing in mountinfos were listed. Also, "name=systemd" needs special handling, so add it. The controllers added were: * for fedoraMountinfo case: name=systemd * for systemdMountinfo case: name=systemd, net_prio * for bedrockMountinfo case: name=systemd, net_prio, pids Signed-off-by: Kir Kolyshkin <[email protected]>
opencontainers · May 20, 2020 · 9e896d7 · 9e896d7
1 parent 88deccc
commit 9e896d7
Showing 1 changed file with 35 additions and 28 deletions.
diff --git a/libcontainer/cgroups/cgroupv1/utils_test.go b/libcontainer/cgroups/cgroupv1/utils_test.go
@@ -188,46 +188,52 @@ func TestGetCgroupMounts(t *testing.T) {
 			mountInfo: fedoraMountinfo,
 			root:      "/",
 			subsystems: map[string]bool{
-				"cpuset":     false,
-				"cpu":        false,
-				"cpuacct":    false,
-				"memory":     false,
-				"devices":    false,
-				"freezer":    false,
-				"net_cls":    false,
-				"blkio":      false,
-				"perf_event": false,
-				"hugetlb":    false,
+				"name=systemd": false,
+				"cpuset":       false,
+				"cpu":          false,
+				"cpuacct":      false,
+				"memory":       false,
+				"devices":      false,
+				"freezer":      false,
+				"net_cls":      false,
+				"blkio":        false,
+				"perf_event":   false,
+				"hugetlb":      false,
 			},
 		},
 		{
 			mountInfo: systemdMountinfo,
 			root:      "/system.slice/docker-dc4eaa1a34ec4d593bc0125d31eea823a1d76ae483aeb1409cca80304e34da2e.scope",
 			subsystems: map[string]bool{
-				"cpuset":     false,
-				"cpu":        false,
-				"cpuacct":    false,
-				"memory":     false,
-				"devices":    false,
-				"freezer":    false,
-				"net_cls":    false,
-				"blkio":      false,
-				"perf_event": false,
+				"name=systemd": false,
+				"cpuset":       false,
+				"cpu":          false,
+				"cpuacct":      false,
+				"memory":       false,
+				"devices":      false,
+				"freezer":      false,
+				"net_cls":      false,
+				"net_prio":     false,
+				"blkio":        false,
+				"perf_event":   false,
 			},
 		},
 		{
 			mountInfo: bedrockMountinfo,
 			root:      "/",
 			subsystems: map[string]bool{
-				"cpuset":     false,
-				"cpu":        false,
-				"cpuacct":    false,
-				"memory":     false,
-				"devices":    false,
-				"freezer":    false,
-				"net_cls":    false,
-				"blkio":      false,
-				"perf_event": false,
+				"name=systemd": false,
+				"cpuset":       false,
+				"cpu":          false,
+				"cpuacct":      false,
+				"memory":       false,
+				"devices":      false,
+				"freezer":      false,
+				"net_cls":      false,
+				"net_prio":     false,
+				"blkio":        false,
+				"perf_event":   false,
+				"pids":         false,
 			},
 		},
 	}
@@ -244,6 +250,7 @@ func TestGetCgroupMounts(t *testing.T) {
 			}
 		}
 		for ss := range td.subsystems {
+			ss = strings.TrimPrefix(ss, CgroupNamePrefix)
 			m, ok := cgMap[ss]
 			if !ok {
 				t.Fatalf("%s not found", ss)