image-index: remove platform.features field #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we still reserve the field name and mark it MUST NOT BE USED? |
Yes. |
This was referenced May 12, 2017
stevvooe
force-pushed
the
remove-features-field
branch
from
7ee20fd
to
1929800
Compare
|
@AkihiroSuda @vbatts Updated to be a reserved property. |
|
LGTM |
|
@opencontainers/image-spec-maintainers PTAL |
|
LGTM |
|
@stevvooe conflicts :( |
|
@philips BAH!!! So close. Wait right there... |
While the intended use of the `platform.features` field was to express the availability of hardware instructions on CPUs, the practicality of expressing and implementing such a standard has been called into question. Much of the functionality is usually hidden deep within kernel code or is defined by hardware vendors in ways that will make the field unusable without future additions. Applications that can make use of such field will likely have other requirements on top of this field that are specific to a deployment. In that regard, it is best to remove this field and defer to hardware to make the decision about what can be run. Signed-off-by: Stephen J Day <[email protected]>
stevvooe
force-pushed
the
remove-features-field
branch
from
1929800
to
e0fa34b
Compare
|
LGTM |
|
@philips review please |
|
LGTM |
|
Thanks, folks! |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the intended use of the
platform.featuresfield was to expressthe availability of hardware instructions on CPUs, the practicality of
expressing and implementing such a standard has been called into
question. Much of the functionality is usually hidden deep within kernel
code or is defined by hardware vendors in ways that will make the field
unusable without future additions. Applications that can make use of such
field will likely have other requirements on top of this field that are
specific to a deployment.
In that regard, it is best to remove this field and defer to hardware to
make the decision about what can be run.
Signed-off-by: Stephen J Day [email protected]
Closes #622