image-layout: use a made-up name/email for author #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image spec shouldn't reference real names/addresses in example content. Switch to the same fake one we use elsewhere. It's like alternative facts. Signed-off-by: Jonathan Boulle <[email protected]>
|
LGTM |
wking
reviewed
Jan 24, 2017
| @@ -132,7 +132,7 @@ $ cat ./blobs/sha256/afff3924849e458c5ef237db5f89539274d5e609db5db935ed3959c90f1 | |||
| $ cat ./blobs/sha256/5b0bcabd1ed22e9fb1310cf6c2dec7cdef19f0ad69efa1f392e94a4333501270 | jq | |||
There was a problem hiding this comment.
You probably want to update this hash to match whatever the canonical form of the new JSON is.
There was a problem hiding this comment.
The JSON is truncated, so I'm not going to do that. Just pretend that whatever is below the ellipses ends up causing a hash collision.
|
LGTM |
1 similar comment
|
LGTM |
|
@caniszczyk Is pullapprove broken? Is there a way to "unstuck" it? |
|
@stevvooe I kicked it, it should be possible for anyone to click the gear icon in the top right and say "re-sync PR" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image spec shouldn't reference real names/addresses in example
content. Switch to the same fake one we use elsewhere. It's like
alternative facts.
Signed-off-by: Jonathan Boulle [email protected]