Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit min layer length in manifest to one #466

Merged
merged 1 commit into from
Nov 24, 2016
Merged

limit min layer length in manifest to one #466

merged 1 commit into from
Nov 24, 2016

Conversation

xiekeyang
Copy link
Contributor

@xiekeyang xiekeyang commented Nov 18, 2016 •
edited
Loading

Spec declares The array MUST have the base image at index 0.
So that we should limit it in JSON shcema, and add test case.
Signed-off-by: xiekeyang [email protected]

@wking
Copy link
Contributor

wking commented Nov 18, 2016 via email

@xiekeyang
Copy link
Contributor Author

@opencontainers/image-spec-maintainers I think this PR is ready to be merged, PTAL.
cc @stevvooe @vbatts

@stevvooe
Copy link
Contributor

stevvooe commented Nov 23, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@jonboulle
Copy link
Contributor

jonboulle commented Nov 24, 2016 •
edited by caniszczyk
Loading

lgtm

Approved with PullApprove

@jonboulle jonboulle merged commit fd1a1af into opencontainers:master Nov 24, 2016
@wking wking mentioned this pull request Dec 1, 2016
Merged
@xiekeyang xiekeyang deleted the limit-layer branch February 20, 2017 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiekeyang @wking @stevvooe @jonboulle