-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up spec to remove non-spec-ish items #458
Conversation
- [Notational Conventions](#notational-conventions) | ||
- [Overview](#overview) | ||
- [Understanding the Specification](#understanding-the-specification) | ||
- [Media Types](media-types.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indent? You should replace the earlier tab with four spaces (opencontainers/runtime-spec#495).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I think this is a step in the right direction, although it will I also think we should merge the “Overview” and “Understanding the |
@@ -118,4 +118,4 @@ Instead they MUST ignore unknown properties. | |||
} | |||
``` | |||
|
|||
[runtime-platform]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0-rc2/config.md#platform | |||
[runtime-platform2]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0-rc2/config.md#platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rename this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current approach to single-file PDF/HTML generation is to feed all the Markdown into Pandoc. Pandoc seems to treat them as a single, concatenated file internally and doesn't like seeing the same reference defined more than once, so he's giving this a globally-unique name to avoid conflicting with the entry in config.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah, what a mess. I really just want to drop PDF/HTML.
@duglin rebase please? |
rebased, but I'd appreciate a double-check to make sure I didn't drop anything from README.md or spec.md. |
Conflicts again |
Signed-off-by: Doug Davis <[email protected]>
rebased |
This landed in 836fb1c ([ReadMe] Add Compliance Language, 2016-10-11, opencontainers#432) but was removed in 27508e2 (Clean-up spec to remove non-spec-ish items, 2016-11-14, opencontainers#458), likely accidentally during a rebase. Signed-off-by: W. Trevor King <[email protected]>
Per the oci f2f at kubecon. Similar changes what is in: opencontainers/runtime-spec#626
Signed-off-by: Doug Davis [email protected]