-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: Limit schemaVersion to 2 and enumerate mediaType #404
schema: Limit schemaVersion to 2 and enumerate mediaType #404
Conversation
|
On Thu, Oct 20, 2016 at 09:48:41PM -0700, xiekeyang wrote:
Oops, yeah. Fixed with the just-pushed 00f177b.
I think there are two things going on here: what you are and what you reference. #304 is about who you reference, and the pattern is that we require implementations to support appropriate OCI types but allow images and implementations to use other types as well. This PR, on the other hand, is about declaring what you are, and there's only one good answer for that. An |
I've just pushed an additional commit (801699e) fixing the |
needs a rebase |
801699e
to
c23165c
Compare
For manifests and manifest lists, to match the requirements from their Markdown definitions. Signed-off-by: W. Trevor King <[email protected]>
Generated with: $ make schema-fs Signed-off-by: W. Trevor King <[email protected]>
We want to go from the Docker type (the key) to the OCI type (the value), not the other way around. Signed-off-by: W. Trevor King <[email protected]>
c23165c
to
dad01a1
Compare
On Wed, Nov 16, 2016 at 02:38:58PM -0800, Brandon Philips wrote:
Rebased onto master and rebuilt schema/fs.go with c23165c → dad01a1. It's probably best if you order up all the JSON-Schema-touching PRs An alternative would be to ask contributors to not update fs.go and |
For manifests and manifest lists, to match the requirements from their Markdown definitions.