Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs-go/v1: add nondistributable media type #297

Merged
merged 1 commit into from
Sep 13, 2016

Conversation

runcom
Copy link
Member

@runcom runcom commented Sep 12, 2016

Takes care of adding the new media type in the Go types from #233 - so that can proceed and be merged w/o any other interruption.

/cc @stevvooe @philips @vbatts

Signed-off-by: Antonio Murdaca [email protected]

@jonboulle
Copy link
Contributor

jonboulle commented Sep 12, 2016

lgtm

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Sep 12, 2016 via email

@runcom
Copy link
Member Author

runcom commented Sep 12, 2016

schema/manifest_test.go

what's wrong with schema/manifest_test.go? just add a test?

@wking
Copy link
Contributor

wking commented Sep 12, 2016

On Mon, Sep 12, 2016 at 11:04:57AM -0700, Antonio Murdaca wrote:

schema/manifest_test.go

what's wrong with schema/manifest_test.go? just add a test?

We should exercise the new type to make sure the image tooling handles
it correctly, which includes not choking on it during validation.

@philips
Copy link
Contributor

philips commented Sep 13, 2016

LGTM

Approved with PullApprove

@philips philips merged commit b1d6969 into opencontainers:master Sep 13, 2016
@runcom runcom deleted the nondistributable-mt branch September 13, 2016 06:01
@runcom
Copy link
Member Author

runcom commented Sep 13, 2016

We should exercise the new type to make sure the image tooling handles
it correctly, which includes not choking on it during validation.

@wking that's the wrong test for sure since it's already a mess with media types like ".serialization." but it is not failing since that is testing the MANIFEST as a whole - not that the media types are actually correct... you don't exercise anything in that test - just that the media type field isn't empty...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants