Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inline html/markdown syntax #294

Merged
merged 1 commit into from
Sep 13, 2016
Merged

fix inline html/markdown syntax #294

merged 1 commit into from
Sep 13, 2016

Conversation

xiekeyang
Copy link
Contributor

Signed-off-by: xiekeyang [email protected]

@philips
Copy link
Contributor

philips commented Sep 12, 2016

How is this a typo? markdown allows for intermixing html like this.

@xiekeyang
Copy link
Contributor Author

xiekeyang commented Sep 12, 2016 •
edited
Loading

How is this a typo? markdown allows for intermixing html like this.

Seems it doesn't.
it shows on page as, application/vnd.oci.image.layer.tar+gzip
We want like, application/vnd.oci.image.layer.tar+gzip

@wking
Copy link
Contributor

wking commented Sep 12, 2016

On Sun, Sep 11, 2016 at 08:58:16PM -0700, Brandon Philips wrote:

How is this a typo? markdown allows for intermixing html like this.

There are some rules about inline Markdown inside HTML not being
supported. I haven't dug up a refernce in the Markdown spec, but you
can see the backtics not being converted to code tags in master 1.
So +1 for b0edca4 (although a more specific commit summary would be
nice ;).

@xiekeyang
Copy link
Contributor Author

Update commit summary.

adaptive format character in html block
104ecd1 
Markdown format character is unacceptable in html block.
Should follow html syntax.

Signed-off-by: xiekeyang <[email protected]>
@jonboulle jonboulle changed the title fix typo fix inline html/markdown syntax Sep 12, 2016
@jonboulle
Copy link
Contributor

jonboulle commented Sep 12, 2016 •
edited by caniszczyk
Loading

lgtm

Approved with PullApprove

@philips
Copy link
Contributor

philips commented Sep 13, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@philips philips merged commit 6a6219d into opencontainers:master Sep 13, 2016
@xiekeyang xiekeyang deleted the typo branch November 4, 2016 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiekeyang @philips @wking @jonboulle