serialization: Entrypoint and Cmd nullable #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
force-pushed
the
validation
branch
2 times, most recently
from
66d5a5c
to
24280af
Compare
|
not sure about this. If it is nullable, then it can be omitted. Right? |
|
it should be the same as |
|
i see. Could you rebase? |
This is a spec change based on testing live Docker Hub configs. Volume may be null as found in the hub.docker.com/library/docker image. Signed-off-by: Brandon Philips <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
|
@vbatts done |
|
LGTM |
|
this is unfortunate :-( |
|
LGTM I guess |
Closed
Ghostman2591
approved these changes
Jan 5, 2024
Ghostman2591
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #151 - refer only to the last commit for review
@philips feel free to either cherry-pick my commit from here or wait #151 to be merged first (and I'll rebase)
This patch makes
EntrypointandCmdfields in the serialization schema nullable + adds tests/cc @vbatts