Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for v1.0.0 #56

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented May 12, 2020

The release tag will be created from the merge commit of this PR. Applying an LGTM to this PR is voting for the release. Let's wait for a quorum to merge.

fixes #46

pre_release = false

preface = """\
This if the first official release of the go-digest package. This package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo if

@AkihiroSuda
Copy link
Member

Looks good except a typo

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member

LGTM (for pullapprove)

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.mailmap Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but in case @zhouhaibing089 is around to provide their real name (looks like this came in from distribution/distribution#2435)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a pretty common way to write names, the numbers just shouldn't be there in the author list. If he prefers "Haibing Zhou" like on his Twitter, he is welcome to change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Haibing Zhou is preferred.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in time :)

@thaJeztah
Copy link
Member

w.r.t. pull approve (as it's flaky at times); there's some discussion in opencontainers/runc#2388 (comment) to replace it with "native" GitHub checks

@thaJeztah
Copy link
Member

Asked a review from @stevvooe (👋 ) and @vbatts (👋 )

@dmcgowan
Copy link
Member Author

For release note output, opened containerd/release-tool#13

See https://gist.github.com/dmcgowan/e8830adb764c4ee31ea3fc4428ee8333 for test generation of release notes

Signed-off-by: Derek McGowan <[email protected]>
@stevvooe
Copy link
Contributor

stevvooe commented May 14, 2020

LGTM

Approved with PullApprove

@AkihiroSuda
Copy link
Member

AkihiroSuda commented May 14, 2020

LGTM

Approved with PullApprove

@dmcgowan dmcgowan merged commit ea51bea into opencontainers:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cut new release that includes #38
5 participants