-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for v1.0.0 #56
Conversation
releases/v1.0.0.toml
Outdated
pre_release = false | ||
|
||
preface = """\ | ||
This if the first official release of the go-digest package. This package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo if
Looks good except a typo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM (for pullapprove) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.mailmap
Outdated
Aaron Lehmann <[email protected]> <[email protected]> | ||
Derek McGowan <[email protected]> <[email protected]> | ||
Stephen J Day <[email protected]> <[email protected]> | ||
zhouhaibing <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but in case @zhouhaibing089 is around to provide their real name (looks like this came in from distribution/distribution#2435)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a pretty common way to write names, the numbers just shouldn't be there in the author list. If he prefers "Haibing Zhou" like on his Twitter, he is welcome to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, Haibing Zhou
is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in time :)
w.r.t. pull approve (as it's flaky at times); there's some discussion in opencontainers/runc#2388 (comment) to replace it with "native" GitHub checks |
For release note output, opened containerd/release-tool#13 See https://gist.github.com/dmcgowan/e8830adb764c4ee31ea3fc4428ee8333 for test generation of release notes |
Signed-off-by: Derek McGowan <[email protected]>
The release tag will be created from the merge commit of this PR. Applying an LGTM to this PR is voting for the release. Let's wait for a quorum to merge.
fixes #46