Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

algorithm: More new removal #10

Merged
merged 1 commit into from
Dec 19, 2016
Merged

algorithm: More new removal #10

merged 1 commit into from
Dec 19, 2016

Conversation

wking
Copy link
Contributor

@wking wking commented Dec 17, 2016

Fixes for #9.

@stevvooe
Copy link
Contributor

Because this is returning a crypto.Hash, rather than a digest.Digester, this needs to be New(). This part of the reason this was renamed: it was very confusing which one was which.

@wking
algorithm: More New removal
fe5ffa6 
The remaining New on a cytpo.Hash, so it stays.

Signed-off-by: W. Trevor King <[email protected]>
@wking
Copy link
Contributor Author

wking commented Dec 17, 2016 via email

@stevvooe
Copy link
Contributor

LGTM

@stevvooe stevvooe merged commit abeb4ab into opencontainers:master Dec 19, 2016
wking pushed a commit to wking/go-digest that referenced this pull request Jan 6, 2017
Merge pull request opencontainers#10 from wking/no-specific-commit-su…
8afbcde 
…mmary-limit

CONTRIBUTING: Don't specify a 50-char limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wking @stevvooe