Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit confirmed extension proto #155

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Commit confirmed extension proto #155

merged 4 commits into from
Nov 28, 2023

Conversation

kidiyoor
Copy link
Contributor

@kidiyoor kidiyoor commented Oct 11, 2023

This is a supporting PR for openconfig/reference#197. Older discussion and reference/handling document PR can be found here: openconfig/reference#196

Netconf rfc6241 has a definition for confirmed commit. as follow-

  If the <persist> element is not given in the confirmed commit
   operation, any follow-up commit and the confirming commit MUST be
   issued on the same session that issued the confirmed commit.  If the
   <persist> element is given in the confirmed <commit> operation, a
   follow-up commit and the confirming commit can be given on any
   session, and they MUST include a <persist-id> element with a value
   equal to the given value of the <persist> element.

Example implementations of confirmed commit(There are other vendors who support confirmed commit but not listed here)-

  1. Cisco - https://www.cisco.com/c/en/us/td/docs/routers/xr12000/software/xr12k_r3-9/system_management/command/reference/yr39xr12k_chapter5.html#wp1873946320 - Confirmed commit can be issued as part of CLI cmds - commit confirmed <seconds> eg. RP/0/0/CPU0:router(config)# commit confirmed 60. The confirmation can be issued by entering a commit in the same SSH session.

  2. Juniper - https://www.juniper.net/documentation/us/en/software/junos/cli/topics/ref/command/commit.html - Confirmed commit can be issued as part of CLI cmds - commit confirmed <minutes>. Eg. user@host# commit confirmed 1. The confirmation can be issued by entering a commit or commit check in the same SSH session.

There is an optional comment field that can be passed which can hold any client provided description.

Updating after discussion during community meeting. Provide clarity in comments regarding- 
a. Client provided ID.
b. No more than 1 commit can be active at a time.
@dplore
Copy link
Member

dplore commented Nov 14, 2023

Please add 2 references to documentation of similar capability and add to the first comment in this PR.

@kidiyoor
Copy link
Contributor Author

Added netconf definition and two example reference implementation. It looks like in the CLI implementations support for <persist-id> is not added hence confirmation can only be issued in the same SSH session.

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reviewed in the 14-Nov-2023 OC Operators meeting without objection. Issuing a last call for two weeks (ending 28-Nov-2023) for any other comments on this change.

@dplore dplore merged commit 4423cef into openconfig:master Nov 28, 2023
1 check passed
@hellt
Copy link
Contributor

hellt commented Nov 28, 2023

It is a pity we haven't addressed the timer reset @dplore

@dplore
Copy link
Member

dplore commented Nov 28, 2023

Hi @hellt please submit a new PR to add the timer reset. Be sure to include references. It seems like a straight forward addition? We can wait for the timer reset to be merged before creating a new gnmi release tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants