RT-2.12 Fixed with deviations & minor changes #3513
+140
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Edited dp2v6Route such that it is advertised as ISIS route.
- Set separate tag value for IPv4 & IPv6 as per README.
- Added missing metricPropogation parameter.
PS: Script needs alteration (apart from this PR) such that it adheres to README.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #3513 / 5061effVirtual Devices
Hardware Devices
|
- Reverted dp2v6 route
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
-Resolving conflicts.
Merge branch 'SN-RT2dot12' of https://github.com/nokia/featureprofiles into SN-RT2dot12
Merge remote-tracking branch 'upstream/main' into SN-RT2dot12
|
/fptest virtual |
Pull Request Test Coverage Report for Build 11970930166Details
💛 - Coveralls |
dplore
requested changes
Nov 16, 2024
| t.Fatalf("Unexpected error updating SRL static-route tag-set: %v", err) | ||
| } | ||
| default: | ||
| t.Fatalf("Unsupported vendor %s for deviation 'UseVendorNativeACLConfiguration'", d.Vendor()) |
There was a problem hiding this comment.
Suggested change
| t.Fatalf("Unsupported vendor %s for deviation 'UseVendorNativeACLConfiguration'", d.Vendor()) | |
| t.Fatalf("Unsupported vendor %s for deviation 'EnableTableConnections'", d.Vendor()) |
There was a problem hiding this comment.
Updated as per comments.
...ure/isis/otg_tests/static_route_isis_redistribution/static_route_isis_redistribution_test.go
Outdated
Show resolved
Hide resolved
|
Please also check that fptest virtual test passes on your platform as expected |
…_route_isis_redistribution_test.go Co-authored-by: Darren Loher <[email protected]>
…_route_isis_redistribution_test.go Co-authored-by: Darren Loher <[email protected]>
|
/fptest nokia-srl |
|
/fptest virtual |
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
|
Shared hardware logs through https://partnerissuetracker.corp.google.com/issues/380289415 please do check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: Script needs alteration (apart from this PR) such that it adheres to README.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."