Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnmi-1.4: fix deviations for nokia #3374

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

LimeHat
Copy link
Contributor

@LimeHat LimeHat commented Aug 12, 2024

This deviation was added in #3046 likely by mistake, hence removing it once again.


This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.

This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.
@LimeHat LimeHat requested review from a team as code owners August 12, 2024 19:16
@OpenConfigBot
Copy link

OpenConfigBot commented Aug 12, 2024

Pull Request Functional Test Report for #3374 / 36b3750

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.4: Telemetry: Inventory
Cisco 8000E status
gNMI-1.4: Telemetry: Inventory
Cisco XRd status
gNMI-1.4: Telemetry: Inventory
Juniper ncPTX status
gNMI-1.4: Telemetry: Inventory
Nokia SR Linux status
gNMI-1.4: Telemetry: Inventory
Openconfig Lemming status
gNMI-1.4: Telemetry: Inventory

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-1.4: Telemetry: Inventory
Cisco 8808 status
gNMI-1.4: Telemetry: Inventory
Juniper PTX10008 status
gNMI-1.4: Telemetry: Inventory
Nokia 7250 IXR-10e status
gNMI-1.4: Telemetry: Inventory

Help

@coveralls
Copy link

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10357977979

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.252%

Totals Coverage Status
Change from base Build 10350992044: 0.0%
Covered Lines: 1983
Relevant Lines: 3589

💛 - Coveralls

Copy link
Contributor

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nsadhasivam nsadhasivam merged commit 76b2785 into openconfig:main Aug 13, 2024
13 checks passed
@LimeHat LimeHat deleted the gnmi-1.4-fixdeviations branch August 13, 2024 16:54
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Aug 14, 2024
This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Aug 23, 2024
This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants