Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAI-PTF][1.10]Fix issue when transfer make parameter GEN_SAIRPC_OPTS #1674

Merged

Conversation

richardyu-ms
Copy link
Collaborator

Fix issue when transfer make param GEN_SAIRPC_OPTS with space in it

when transfer GEN_SAIRPC_OPTS with multi parameters in it and use the space to split it, there is a issue for translate from build system to actual make system.

--adapter_logger --skip_error=-2

add quota when transfer the parameter

Test Done:
Verified in local container
Verified in build system

Signed-off-by: richardyu-ms [email protected]

Fix issue when transfer make param GEN_SAIRPC_OPTS with space in it

when transfer GEN_SAIRPC_OPTS with multi parameters in it and use the
space to split it, there is a issue for translate from build system to
actual make system.
```
--adapter_logger --skip_error=-2
```

add quota when transfer the parameter

Test Done:
Verified in local container
Verified in build system

Signed-off-by: richardyu-ms <[email protected]>
Copy link

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardyu-ms richardyu-ms merged commit 95e7803 into opencomputeproject:v1.10 Dec 4, 2022
richardyu-ms added a commit to richardyu-ms/sonic-sairedis that referenced this pull request Dec 4, 2022
richardyu-ms added a commit to sonic-net/sonic-sairedis that referenced this pull request Dec 4, 2022
Advance SAI header include change
- opencomputeproject/SAI#1674 opencomputeproject/SAI@95e7803

Signed-off-by: richardyu-ms <[email protected]>

Signed-off-by: richardyu-ms <[email protected]>
@richardyu-ms richardyu-ms deleted the fix_GEN_SAIRPC_OPTS_1.10 branch January 1, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants