style(buttons): styling buttons according to Figma standards #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HipsterBrown
reviewed
Sep 7, 2018
| @@ -108,7 +108,14 @@ injectGlobal` | |||
| } | |||
|
|
|||
| a:hover { | |||
| color: #797d80; | |||
| color: #ffffff; | |||
There was a problem hiding this comment.
Not all anchor tags are buttons, so it doesn't make sense to use a global style for background color on all anchor tags. This should really be a part of a Button component. One of which exists, as well as the StyledLink that can be styled like a button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buttons should follow the design standards according to Figma:
Fixes opencollective/opencollective#1277