Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve admin approval flow (#1068) #504

Closed

Conversation

FadySamirSadek
Copy link

solves #1068
Todo

  • Add translations (will probably use google translate or get some help)
  • Fix styling (I did not find any code style guideline in the repo so I tried to make it look like the previous code as much as I could)
    -Another thing I think we should create a component for warning and success messages that contain all the HTML instead of sending just text to the screen

@FadySamirSadek
Copy link
Author

@znarf
Copy link
Member

znarf commented Jun 13, 2018

Hi @FadySamirSadek, Thank you for your contribution, looking good. You don't need to take care of the translations.

The only styling rules that we enforce are the one from our eslint configuration. You can run npm run lint to check that. After that, always a good idea to make it looks like the rest of the codebase.

Can you share a screenshot of the screen with your modification?

Let me know if you want to do the warning/success component now or would like to submit that later as an improvement.

Let's try to merge that this week!

@xdamman
Copy link
Member

xdamman commented Nov 27, 2018

This is a great improvement. What's the status?

@znarf
Copy link
Member

znarf commented Feb 22, 2019

Sorry @FadySamirSadek, I'll have to close it because it's getting old.

Feel free to revisit that with a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants