-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add funds to Organizations [Issue 1080] #418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarete
force-pushed
the
issue-1080
branch
4 times, most recently
from
May 23, 2018 13:09
c43992d
to
9f25b8b
Compare
* feat: Replace dropdown combo with an actual list; * fix: Use paginated GraphQL methods * chore: Throw rivers of CSS away
Since it's going to be used in multiple places, that's easier to be done with the form to just receive selectedCollective & hostCollective and do all the rest.
The hostCollective object is available at the page level and the same object can be passed forward. Although the query within the component CollectivePickerWithData does look for the same object again, it's still worth using the one retrieved by the upper level component because: 1) I hope one day we stop querying the same object more than once 2) the code looks simpler this way.
This was referenced Apr 14, 2021
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.