Migrate UNSAFE_componentWillReceiveProps #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
eloyekunle
force-pushed
the
migrate/unsafeWillReceiveProps
branch
from
6cb908e to
185c987
Compare
eloyekunle
changed the title
Betree
approved these changes
Jun 18, 2019
znarf
approved these changes
Jun 18, 2019
znarf
reviewed
Jun 18, 2019
| @@ -463,7 +463,7 @@ class CreateExpenseForm extends React.Component { | |||
| type="email" | |||
| name="paypalEmail" | |||
| key={`paypalEmail-${get(LoggedInUser, 'id')}`} | |||
| defaultValue={this.state.expense.paypalEmail} | |||
There was a problem hiding this comment.
Initially, paypalEmail is null before the prop updates. defaultValue binds to the initial value during the first render so it doesn't change if the user is actually logged in and has a default email.
This change fixes that.
znarf
reviewed
Jun 18, 2019
| // If there was an existing card, select that | ||
| if (paymentMethodsList.length > 0) { | ||
| this.handleChange({ uuid: paymentMethodsList[0].uuid }); | ||
| if (!prevProps.paymentMethodsList && paymentMethodsList) { |
There was a problem hiding this comment.
To avoid infinite loops, since we're setting state in componentDidUpdate. This ensures that the state will only be updated for this condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes opencollective/opencollective#1438