Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to skip users #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bombsimon
Copy link

Add a new query parameter skip that can be specified multiple times to skip specific users. Can be used to filter out bots or other users that don't want to be a part of the contributors list.

Add a new query parameter `skip` that can be specified multiple times to
skip specific users. Can be used to filter out bots or other users that
don't want to be a part of the contributors list.
@@ -32,13 +32,18 @@ export async function fetchContributors({ collectiveSlug }) {
// Fetch data from Open Collective API
const query = gql`
query GithubContributors($collectiveSlug: String) {
Collective(slug: $collectiveSlug) {
collective(slug: $collectiveSlug) {
Copy link
Author

@bombsimon bombsimon Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is relevant here but due to opencollective/opencollective#6899 I couldn't test this towards the dev API. Instead I ran it against both https://api.opencollective.com/graphql and https://api.opencollective.com/graphql/v2 and both of them defines this method as lowercase collective.

Similarly there's no field named githubContributors but a contributors witch contains contributor nodes.

I can revert these changes that's not related to banner.js if you can help me confirm it's not needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I never really got the dev API working I was browsing around the code. Seems like the local V1 is using Collective but neither ones posted above or V2 in the dev API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant