Better README #383
Better README #383
Conversation
|
What is the purpose of |
|
Please ignore it. It is for me to install ARPACK for my development. |
|
Can you had commits for each remark above (easier to follow-up) before merging.
I can't, you added it in the PR: please, revert it or push-force. |
|
@fghoussen I have deleted the install.sh. Is there anything pending from myside? |
@vickysharma0812: Yes, can you had 1 commit for each remark (easier to follow-up) I made in the review before merging. |
sylvestre
force-pushed
the
vickysharma0812
branch
from
1f7a32a to
0d47d58
Compare
|
@vickysharma0812: Yes, can you had 1 commit for each remark (easier to follow-up) I made in the review before merging. |
I have deleted install.sh This is now safe to merge with the main branch.
fghoussen
force-pushed
the
vickysharma0812
branch
from
23187ef to
9264ed6
Compare
|
We are about to create a new release #394: @vickysharma0812, do you want to finish this PR (#383 (comment))? If not now, will be for next release. |
Honestly speaking, I am confused about what should I do. Can you please tell me, I am sorry for the inconvenience. |
You proposed a PR to make README more readable. Before merging, I asked you to apply several modifications (example: #383 (comment)) you reacted to 👍 : now, you should add 1 commit for each remark above (the last one behing #383 (comment)). Also please rebase your PR branch on master |
|
@vickysharma0812: just realized you add modifications. Missed that, sorry. |
Pull request purpose
related to issue #382, and enhancement in documentation.
Detailed changes proposed in this pull request