Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass complex parameters by pointers to constant instead of by value #124

Closed
wants to merge 1 commit into from

Conversation

10110111
Copy link
Contributor

@10110111 10110111 commented Jun 6, 2018

Fortran-C bindings seem to expect it.

This fixes #123. Both C and C++ tests will no longer
crash. But the C test will fail (but still pass on x86_64). This might be due to an error in the
test itself.

…as Fortran-C bindings expect it

This fixes opencollab#123. Both C and C++ tests will no longer
crash. But the C test will fail. This might be due to an error in the
test itself.
@dbeurle
Copy link
Contributor

dbeurle commented Jun 6, 2018

The complex C test appears to be the same as for the c++ one. I can write a test for the double case in C++ to rule that out, if that would help?

@10110111
Copy link
Contributor Author

10110111 commented Jun 6, 2018

Actually a good idea. I've simply replaced s/\<float\>/double/g in the relevant pieces of C++ test, and now it crashes. I suppose I'll retract this pull request for now.

@10110111 10110111 closed this Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icb_arpack_cpp: testsuite fails on i386
3 participants