Add unit test

[smatthewenglish]

unit test updates with question rues

[ruiting]

who is h1395010?

Ruiting Lian

On Mon, Oct 27, 2014 at 2:42 PM, h1395010 [email protected] wrote:

unit test updates with question rues

You can merge this Pull Request by running

git pull https://github.com/h1395010/relex add-unit-test

Or view, comment on, or merge it at:

#184
Commit Summary

• updates unit tests with questions
• modification to rule parameters

File Changes

• M src/java_test/relex/test/TestRelEx.java
  https://github.com/opencog/relex/pull/184/files#diff-0 (442)

Patch Links:

• https://github.com/opencog/relex/pull/184.patch
• https://github.com/opencog/relex/pull/184.diff

—
Reply to this email directly or view it on GitHub
#184.

[amebel]

@anitzkin matthew had just added some unit tests for questions would you pls check them and see whether they suffice in covering your recent changes.

[amebel]

@ruiting h1395010 is matthew :-)

[anitzkin]

Right on. Will do . . . .

[anitzkin]

Obviously this is not a full set o fdependency relations. I assume the word 'slavers' is throwing it off. Try the same sentence with a more standard indirect object and see if you get sensible output. if you do, change the example sentence. If not, make sure the comments reflect that this type of question still doesn't work; it will require more revision of the sem-algs.

[amebel]

@linas h1395010 aka Matthew is a new member of the HK team and is starting out by working on creating new tests and fixing the failing ones so as to get a sense of what is going on the comprhension pipeline.

A small introduction :-)

[linas]

Thanks @amebel -- please merge this when you think it's ready ... either now or after fixes come in for Aaron's comments.

We should probably have some sort of annotation: "this parse has been reviewed by XX and looks correct", since I know that the unit test does have a number of entres in it that are just wrong.