Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparatives Without More/less terms #123

Merged
merged 2 commits into from
Jul 16, 2014
Merged

Conversation

kkasunperera
Copy link
Contributor

@ruiting @linas please check newly added test sentences.


//Comparatives Without More/less terms
rc &= test_sentence ("Her great-grandson is nicer than her great-granddaughter.",
"_subj(is, great grandson)\n"+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, the dash in great-grandson is missing, but below its present... ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a TYPO, I wanted to omit "-" from all the relationships. The Relex doesn't output the dash "-", go I guess that is not a bug?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the dashes? They seem just fine to me!

@linas
Copy link
Member

linas commented Jul 16, 2014

Other than the highly inconsistent normalization, and the one LG bug, this looks reasonable, so I'll merge. Please fix the normalization as you get the chance.

linas added a commit that referenced this pull request Jul 16, 2014
Comparatives Without More/less terms
@linas linas merged commit 599462a into opencog:master Jul 16, 2014
@linas
Copy link
Member

linas commented Jul 16, 2014

I guess I should have let @ruiting review too ... sorry, I forgot. These looked straightforward to me.

@ruiting
Copy link
Contributor

ruiting commented Jul 16, 2014

@linas I agreed with your comments... I can't get normal internet for this week, so it will be great if you can just review them. Thanks. I think we have already discussed most of the issues about comparatives through the email from a couple weeks ago...

@linas
Copy link
Member

linas commented Jul 17, 2014

OK, so the .a-c subscript in link-grammar means its an "adjective-comparative"; this is converted to the relex POS tags in data/relex-tagging.algs The stemming is done in src/java/relex/morph/*java

I'm just confused about why some of the comparatives get normalized, and sometimes they don't. Is this a bug in relex, or is this due to WordNet being inconsistent?

@ruiting
Copy link
Contributor

ruiting commented Jul 17, 2014

It seems "bigger" can be an adjective itself in WordNet...

Overview of adj bigger

The adj bigger has 1 sense (first 1 from tagged texts)

  1. (9) bigger, larger -- (large or big relative to something else)

@linas
Copy link
Member

linas commented Jul 17, 2014

OK, so I take that as the answer "Its a feature (not a bug) in WordNet"

@linas
Copy link
Member

linas commented Jul 17, 2014

OK, so if I may: a mini-lecture: The current relex morphology/normalization code is mis-designed/mis-architected. Its good enough to handle most cases, but can fail badly. The problem is that the current code only looks at single words; it should be looking at larger parts of the sentence to do this.

Examples of failures: better-> good? or -> well? Depends on the actual sentence. I've seen other examples in the past, I can't remember them.

The correct design would understand normalization as the inverse of a "lexical function": https://en.wikipedia.org/wiki/Lexical_function

What we should be doing is not only normalizing, but we should also be identifying the lexical function that applies to the given situation. This would also make relex far more useful for language generation (.... this last comment is for you @ruiting !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants