Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to output json format reports #768

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

LucoDevro
Copy link

  • Does not fix an open issue: it adds functionality
  • description of feature/fix

Json files are easier to parse for automated high-throughput applications. Since this output option was silently supported in the API, I exposed it via a Boolean flag.

  • tests added/passed

All tests passed (make qa).

Json files are easier to parse for automated high-throughput applications. Since this output option was silently supported in the API, I exposed it via a Boolean flag.
@Midnighter
Copy link
Member

Hi @LucoDevro,

Thank you for the contribution. I agree that this is very useful. It's been on my mind for years now, but I only get to work on memote in my spare time. I've held off on making this available so far, because I thought it would not be that useful without also offering a solution to load JSON files and creating a report from that.

Do you have a use just for this part already?

@LucoDevro
Copy link
Author

I'm setting up a high-throughput curation workflow and memote nicely puts together some tests. At some point, I needed to get the identifiers of the flagged reactions of course, and those are easier to get from a json than from an html.

@Midnighter
Copy link
Member

In that case, please also take a look at https://github.com/opencobra/jeweler which is a nextflow pipeline for running memote on many samples.

@LucoDevro
Copy link
Author

Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants