Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-102: use shade plugin to repack and trim jars #256

Merged
merged 21 commits into from
Jul 1, 2024

Conversation

marek-parfianowicz
Copy link
Member

Issue #102: do not create repacked libraries of clover-antlr, clover-cajo and clover-slf4j; instead of this use original artifacts of antlr:antlr, gnu.cajo:cajo and org.slf4j:slf4j-api; later use maven-shade-plugin to repack these libraries inside clover-runtime.jar and clover.jar

… and clover-slf4j; instead of this use original artifacts of antlr:antlr, gnu.cajo:cajo and org.slf4j:slf4j-api; later use maven-shade-plugin to repack these libraries inside clover-runtime.jar and clover.jar
@marek-parfianowicz marek-parfianowicz self-assigned this Apr 10, 2024
…eate an artifact, added additional dependencies to javadoc
…ad of clover-all artifact; using shade instead of assembly plugin for this; we no longer take repacked libraries for testing in clover-groovy, as they're already inside clover-core; disable default execution (default-jar id) for maven-jar-plugin in clover-groovy as real jar is created using assembly plugin; don't pack MANIFEST.MF from antlr in clover-runtime
…braries are being shaded during packaging of clover-runtime and clover-core; updated majority of 'import clover.*'; simplified clover-fastutil as now it only installs a jar; solved problems in clover-eclipse and clover-idea where it could not compile due to repacked classes (which was not visible in IDE)
…d thus removed clover-jtreemap module; removed mentions in docs and build files; solved binary incompatiblity between 1.1.0 and 1.1.3
…lr:antlr in clover-groovy, corrected getCloverLibs helper method
…(build fails due to repacked vs non-repacked Velocity)
…(build fails due to repacked vs non-repacked Velocity)
… in Velocity, so rolling-back to a previous solution with repacking via jarjar and ant filters; added maven-shade-plugin to clover-ant as the module referenced some classes from Lang3 without renamed package in bytecode; updated shade plugin to the latest 3.6.0 version
…ll be done by maven-shade-plugin; a reason for this change is that unit tests for clover-core rely on non-shaded dependencies
@marek-parfianowicz marek-parfianowicz changed the title OC-102: use shade and proguard plugins to repack and trim jars OC-102: use shade plugin to repack and trim jars Jul 1, 2024
@marek-parfianowicz marek-parfianowicz merged commit 0634312 into master Jul 1, 2024
5 checks passed
@marek-parfianowicz marek-parfianowicz deleted the OC-102-shade-and-proguard branch July 1, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant