-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OC-102: use shade plugin to repack and trim jars #256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and clover-slf4j; instead of this use original artifacts of antlr:antlr, gnu.cajo:cajo and org.slf4j:slf4j-api; later use maven-shade-plugin to repack these libraries inside clover-runtime.jar and clover.jar
…eate an artifact, added additional dependencies to javadoc
…ad of clover-all artifact; using shade instead of assembly plugin for this; we no longer take repacked libraries for testing in clover-groovy, as they're already inside clover-core; disable default execution (default-jar id) for maven-jar-plugin in clover-groovy as real jar is created using assembly plugin; don't pack MANIFEST.MF from antlr in clover-runtime
…braries are being shaded during packaging of clover-runtime and clover-core; updated majority of 'import clover.*'; simplified clover-fastutil as now it only installs a jar; solved problems in clover-eclipse and clover-idea where it could not compile due to repacked classes (which was not visible in IDE)
…rings); excluded MANIFEST.MF from jdom
…d thus removed clover-jtreemap module; removed mentions in docs and build files; solved binary incompatiblity between 1.1.0 and 1.1.3
…lr:antlr in clover-groovy, corrected getCloverLibs helper method
…(build fails due to repacked vs non-repacked Velocity)
…(build fails due to repacked vs non-repacked Velocity)
… in Velocity, so rolling-back to a previous solution with repacking via jarjar and ant filters; added maven-shade-plugin to clover-ant as the module referenced some classes from Lang3 without renamed package in bytecode; updated shade plugin to the latest 3.6.0 version
…ll be done by maven-shade-plugin; a reason for this change is that unit tests for clover-core rely on non-shaded dependencies
marek-parfianowicz
changed the title
OC-102: use shade and proguard plugins to repack and trim jars
OC-102: use shade plugin to repack and trim jars
Jul 1, 2024
clover-core/src/main/java/org/openclover/core/PrematureLibraryLoader.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #102: do not create repacked libraries of clover-antlr, clover-cajo and clover-slf4j; instead of this use original artifacts of antlr:antlr, gnu.cajo:cajo and org.slf4j:slf4j-api; later use maven-shade-plugin to repack these libraries inside clover-runtime.jar and clover.jar