Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK-7207 - Fix Organization migration issue #2531

Merged
merged 2 commits into from
Nov 18, 2024
Merged

TASK-7207 - Fix Organization migration issue #2531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be61b15
app: ensure all jobs have an attributes field, #TASK-7207
pfurio Nov 15, 2024
d30dac9
app: Always rename studies from storage when changing organization id…
j-coll Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 42 additions & 26 deletions ...-app/src/main/java/org/opencb/opencga/app/migrations/v3/v3_0_0/OrganizationMigration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import org.apache.commons.lang3.StringUtils;
import org.bson.Document;
import org.bson.conversions.Bson;
import org.opencb.commons.datastore.core.ObjectMap;
import org.opencb.commons.datastore.mongodb.MongoDataStore;
import org.opencb.commons.utils.CryptoUtils;
import org.opencb.commons.utils.FileUtils;
Expand All @@ -27,6 +28,7 @@
import org.opencb.opencga.catalog.utils.FqnUtils;
import org.opencb.opencga.catalog.utils.ParamUtils;
import org.opencb.opencga.core.api.ParamConstants;
import org.opencb.opencga.core.common.JacksonUtils;
import org.opencb.opencga.core.common.TimeUtils;
import org.opencb.opencga.core.config.AuthenticationOrigin;
import org.opencb.opencga.core.config.Configuration;
Expand Down Expand Up @@ -510,38 +512,46 @@ private void changeFqns() throws CatalogDBException, MigrationException {
Document datastores = internal.get("datastores", Document.class);
if (datastores != null) {
Document variant = datastores.get("variant", Document.class);
DataStore dataStore;
boolean updateVariant = false;
if (variant == null) {
DataStore dataStore = VariantStorageManager.defaultDataStore(configuration.getDatabasePrefix(), oldProjectFqn);
logger.info("Undefined variant \"internal.datastores.variant\" at project '{}'.", oldProjectFqn);

// Update only if the project exists in the variant storage
try (VariantStorageEngine variantStorageEngine = storageEngineFactory
.getVariantStorageEngine(dataStore.getStorageEngine(), dataStore.getDbName())) {
if (variantStorageEngine.getMetadataManager().exists()) {
logger.info("Project exists in the variant storage. Setting variant data store: {}", dataStore);
dataStore = VariantStorageManager.defaultDataStore(configuration.getDatabasePrefix(), oldProjectFqn);
updateVariant = true;
} else {
dataStore = JacksonUtils.getDefaultObjectMapper().convertValue(variant, DataStore.class);
}
// Update only if the project exists in the variant storage
try (VariantStorageEngine variantStorageEngine = storageEngineFactory
.getVariantStorageEngine(dataStore.getStorageEngine(), dataStore.getDbName())) {
logger.info("Project '{}' exists in the variant storage.", oldProjectFqn);
if (variantStorageEngine.getMetadataManager().exists()) {
if (updateVariant) {
logger.info("Undefined variant \"internal.datastores.variant\" at project '{}'.", oldProjectFqn);
set.append("internal.datastores.variant", new Document()
.append("storageEngine", dataStore.getStorageEngine())
.append("dbName", dataStore.getDbName())
.append("options", new Document()));

for (String oldStudyFqn : variantStorageEngine.getMetadataManager().getStudies().keySet()) {
String newStudyFqn = FqnUtils.buildFqn(this.organizationId, projectId, FqnUtils.parse(oldStudyFqn).getStudy());
logger.info("Changing study fqn from '{}' to '{}'", oldStudyFqn, newStudyFqn);
variantStorageEngine.getMetadataManager().updateStudyMetadata(oldStudyFqn, studyMetadata -> {
studyMetadata.setName(newStudyFqn);
studyMetadata.getAttributes().put("OPENCGA.3_0_0", new Document()
.append("date", date)
.append("oldFqn", oldStudyFqn)
);
});
}
} else {
logger.info("Project does not exist in the variant storage. Skipping");
logger.info("Datastore variant at project '{}': {}", oldProjectFqn, datastores);
}
} catch (StorageEngineException | IOException e) {
throw new RuntimeException(e);
}

for (String oldStudyFqn : variantStorageEngine.getMetadataManager().getStudies().keySet()) {
String study = FqnUtils.parse(oldStudyFqn).getStudy();
String newStudyFqn = FqnUtils.buildFqn(this.organizationId, projectId, study);
logger.info("Changing study fqn from '{}' to '{}'", oldStudyFqn, newStudyFqn);
variantStorageEngine.getMetadataManager().updateStudyMetadata(oldStudyFqn, studyMetadata -> {
studyMetadata.setName(newStudyFqn);
studyMetadata.getAttributes().put("OPENCGA_3_0_0", new ObjectMap()
.append("date", date)
.append("oldFqn", oldStudyFqn)
);
});
}
} else {
logger.info("Project '{}' does not exist in the variant storage. Skipping", oldProjectFqn);
}
} catch (StorageEngineException | IOException e) {
throw new RuntimeException(e);
}
}
}
Expand Down Expand Up @@ -579,9 +589,15 @@ private void changeFqns() throws CatalogDBException, MigrationException {
))
);

// Ensure all jobs have attributes field
Bson jobQuery = Filters.eq("attributes", null);
Bson update = new Document("$set", new Document("attributes", new Document()));
jobCollection.updateMany(jobQuery, update);
jobDeletedCollection.updateMany(jobQuery, update);

// Change fqn in all jobs that were pointing to this study
Bson jobQuery = Filters.eq("studyUid", studyUid);
Bson update = new Document("$set", new Document()
jobQuery = Filters.eq("studyUid", studyUid);
update = new Document("$set", new Document()
.append("study.id", newFqn)
.append("attributes.OPENCGA.3_0_0", new Document()
.append("date", date)
Expand Down
1 change: 1 addition & 0 deletions opencga-core/src/main/java/org/opencb/opencga/core/models/project/DataStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public String toString() {
final StringBuilder sb = new StringBuilder("DataStore{");
sb.append("storageEngine='").append(storageEngine).append('\'');
sb.append(", dbName='").append(dbName).append('\'');
sb.append(", options=").append(options);
sb.append('}');
return sb.toString();
}
Expand Down
5 changes: 5 additions & 0 deletions ...-hadoop-core/src/main/java/org/opencb/opencga/storage/hadoop/app/VariantMetadataMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import org.opencb.biodata.models.variant.VariantFileMetadata;
import org.opencb.commons.datastore.core.ObjectMap;
import org.opencb.commons.datastore.core.QueryOptions;
import org.opencb.opencga.core.common.TimeUtils;
import org.opencb.opencga.core.tools.ToolParams;
import org.opencb.opencga.storage.core.exceptions.StorageEngineException;
import org.opencb.opencga.storage.core.metadata.VariantStorageMetadataManager;
Expand Down Expand Up @@ -151,6 +152,10 @@ private void rename(String currentStudyName, String newStudyName) throws Storage
int studyId = mm.getStudyId(currentStudyName);
mm.updateStudyMetadata(studyId, studyMetadata -> {
studyMetadata.setName(newStudyName);
studyMetadata.getAttributes().put("rename_" + TimeUtils.getTime(), new ObjectMap()
.append("newName", newStudyName)
.append("oldName", currentStudyName)
);
});
}
}
Expand Down