Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry ingesting a recording #30

Closed
JanKoppe opened this issue Jul 22, 2016 · 9 comments · Fixed by #251
Closed

Retry ingesting a recording #30

JanKoppe opened this issue Jul 22, 2016 · 9 comments · Fixed by #251
Milestone
2.2

Comments

@JanKoppe
Copy link
Contributor

If ingesting a recording has failed (e.g. network problems), the user has to ingest the recording by hand outside of pyCA.

It would be nice if pyCA provides a switch (e.g. pyCA --ingest-now recording-xyz) that can be used to retrigger ingesting a recording.
@lkiesow
Copy link
Member

lkiesow commented Jul 22, 2016

Should that be a command line option or something on the/a web-ui?

On Fri, 22 Jul 2016 01:44:30 -0700
Jan Koppe [email protected] wrote:

If ingesting a recording has failed (e.g. network problems), the user
has to ingest the recording by hand outside of pyCA.

It would be nice if pyCA provides a switch (e.g. pyCA --ingest-now recording-xyz) that can be used to retrigger ingesting a recording.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/lkiesow/pyCA/issues/30

@JanKoppe
Copy link
Contributor Author

A command line option would be a very good start, but being able to
trigger this from the web-ui would be a nice addition. Preferably with a
list of available recordings (dropdown menu).

@JanKoppe
Copy link
Contributor Author

I did a quick implementation in #33 , but I'm not a good python dev at all, so any suggestions for improvements are very, very welcome. It seems to work just fine for me.

@JanKoppe JanKoppe mentioned this issue Nov 18, 2016
Closed
@JanKoppe
Copy link
Contributor Author

This has been effectively implemented with the DB integration and process split.

@lkiesow
Copy link
Member

lkiesow commented Feb 27, 2017

Not quite (at least not if I did not miss anything). If an upload failed, the status would be set to FAILED_UPLOADING and not be picked up again. An easy solution would be to add an action column to the recordings table in the user interface where you have a “Retry Ingest” link which would effectively set the recordings status to FINISHED_RECORDING again.

@JanKoppe
Copy link
Contributor Author

My bad, you are right.

@JanKoppe JanKoppe reopened this Feb 27, 2017
@lkiesow
Copy link
Member

lkiesow commented Mar 6, 2017

From discussion:

Let's have a re-ingest button in the recording table if state > RECORDING_FINISHED

@JanKoppe JanKoppe added this to the 2.1 milestone Mar 20, 2017
@JanKoppe
Copy link
Contributor Author

Would be handled by #73, PATCH-ing the event state to Status.FINISHED_RECORDING, which in turn triggers the ingest service to try another ingest.

@lkiesow lkiesow modified the milestones: 2.2, 2.1 Apr 25, 2017
@lkiesow
Copy link
Member

lkiesow commented Aug 14, 2020

Todo to get this done:

  • Create a retry_ingest REST endpoint
  • The endpoint only accepts identifier for recordings which are in the state FAILED_UPLOADING
  • The endpoint will change the status to FINISHED_RECORDING which will make pyCA automatically try to upload the recording again
  • Add an option to the recording table to trigger an update

mheyen added a commit to mheyen/pyCA that referenced this issue Aug 24, 2020
@mheyen
Patch for issue 30: Adds a re-ingest button in the recording table if…
58522d7 
… the recording is in state FAILED_UPLOADING

clicking the button will change the status of the recording to FINISHED_UPLOADING by sending a request to the pyCA API.
This will modify the state of the recording via PATCH /api/events/<uid> and pyCA will automaitcally try to re-upload the recording.

this fixes opencast#30
@mheyen mheyen mentioned this issue Aug 24, 2020
Merged
lkiesow pushed a commit that referenced this issue Aug 31, 2020
@mheyen
Patch for issue 30: Adds a re-ingest button in the recording table (#251
008be68 
)

Add a re-ingest button

This patch adds a re-ingest button in the recording table for recordings in the state `FAILED_UPLOADING`.
Clicking the button will change the status of the recording to `FINISHED_UPLOADING`,
making pyCA automatically retry ingesting the recording.

This fixes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

Patch for issue 30: Adds a re-ingest button in the recording table mheyen/pyCA
2 participants
@lkiesow @JanKoppe