Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status codes wrong #920

Closed
ThomasBerends opened this issue Oct 1, 2013 · 1 comment
Closed

Status codes wrong #920

ThomasBerends opened this issue Oct 1, 2013 · 1 comment

Comments

@ThomasBerends
Copy link

Example:
http://demo.opencart.com/index.php?route=product/manufacturer/info&manufacturer_id=randommistake

This page is not found, but gives a status 200. If somebody accidentally links to this page, search engines will find it and index it.

This also works for categories:
http://demo.opencart.com/index.php?route=product/category&path=anothermistake

@jamesallsup
Copy link
Contributor

This has been resolved on the 1.5.6.1 branch now, see the recent commits.

Just add

$this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . '/1.1 404 Not Found');

before the not_found.tpl is loaded.

rb2 pushed a commit to rb2/opencart-ce that referenced this issue Nov 3, 2013
Applies to category, manufacturer, product, and information pages.

opencart/opencart#920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants