Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Interleaved Channels #6

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

icecube45
Copy link

@icecube45 icecube45 commented Mar 21, 2020

aasdk is pretty fractured these days, and this pull request should not be merged due to that.
However I'm creating it because of the changes included to src/Messenger/MessageInStream.cpp and include/f1x/aasdk/Messenger/MessageInStream.hpp - the changes made in these files resolves the Interleaved Channel android auto crash,
opencardev/crankshaft#404

At least, it's resolved based on my hour of letting it run/testing on a laptop. This has not been run/compiled on a Pi as of yet. I'm unsure of what unforeseen issues might arise with this code change.

@rsjudka
Copy link

rsjudka commented Mar 22, 2020

Just saw this on intelligent-auto:#13, looks like the exact approach I was planning on taking!

I'll probs port this into my app (after doing some cleanup, just some variable name changes that trigger my OCD :p) and do additional testing to see if anything needs refinement.

@sjdean
Copy link

sjdean commented Apr 23, 2020

Could you advise what you mean by AASDK being pretty fractured?

@ivanixiv
Copy link

ivanixiv commented May 8, 2020

aasdk is pretty fractured these days, and this pull request should not be merged due to that.
However I'm creating it because of the changes included to src/Messenger/MessageInStream.cpp and include/f1x/aasdk/Messenger/MessageInStream.hpp - the changes made in these files resolves the Interleaved Channel android auto crash,
opencardev/crankshaft#404

At least, it's resolved based on my hour of letting it run/testing on a laptop. This has not been run/compiled on a Pi as of yet. I'm unsure of what unforeseen issues might arise with this code change.

Hi, how can i apply your fix on my crankshaft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants