Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc init fix #770

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Arc init fix #770

merged 2 commits into from
Jan 9, 2025

Conversation

at88mph
Copy link
Member

@at88mph at88mph commented Jan 9, 2025

Use built-in cavern configuration to automatically create the parent folder (/home and /projects)
Update documentation

@at88mph
Copy link
Member Author

at88mph commented Jan 9, 2025

CADC-13960

Copy link
Collaborator

@shinybrar shinybrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets merge these changes.

@at88mph at88mph merged commit a2baa0a into opencadc:main Jan 9, 2025
6 of 7 checks passed
@at88mph at88mph deleted the arc-init-fix branch January 9, 2025 21:00
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.60%. Comparing base (f5dd456) to head (e33b4fd).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #770      +/-   ##
============================================
+ Coverage     18.61%   20.60%   +1.99%     
- Complexity      102      118      +16     
============================================
  Files            22       23       +1     
  Lines          1961     1980      +19     
  Branches        270      270              
============================================
+ Hits            365      408      +43     
+ Misses         1544     1521      -23     
+ Partials         52       51       -1     
Flag Coverage Δ
skaha-unittests-coverage 20.60% <ø> (+1.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants