Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Red underline upon sentence completion #520

Open
TheSkallywag opened this issue Feb 1, 2022 · 6 comments
Open

Red underline upon sentence completion #520

TheSkallywag opened this issue Feb 1, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@TheSkallywag
Copy link

I'm using Android 12 and openboard 1.4.4.

I noticed every sentence completed with a period shows a red underline as if it were a spelling mistake. It happened after I upgraded to Android 12 and the issue occurs within all apps.

Screenshot
@TheUglyOne
Copy link

I'm not sure this is specifically an OpenBoard problem. I'm using AOSP Keyboard (included with CalyxOS) and I have the same problem after upgrading to Android 12. Interestingly, if I use the "double space inserts period" option, there's no red underline.

@TheSkallywag
Copy link
Author

I also use the "double space inserts period" option, and there's a red underline. I'm using Samsung Galaxy Ultra 5G.

@EdgeCon
Copy link

EdgeCon commented Mar 26, 2022

I also have the same exact issue. Red line under every word with a period. Android 12, OpenBoard 1.4.4, One UI 4.0, Samsung Galaxy S10+

@kafisc1
Copy link

kafisc1 commented May 23, 2022

Same issue here. A possible fix would be nice.

@jnnkB jnnkB mentioned this issue May 26, 2022
Closed
@icburns
Copy link

icburns commented Aug 18, 2022

Corroborating. This is still present on Android 12 and 13 as of app version 1.4.5.

@EdgeCon
Copy link

EdgeCon commented Aug 18, 2022

Yes, still present for me too. Please fix!

@jnnkB jnnkB added the bug Something isn't working label Aug 18, 2022
icburns added a commit to icburns/openboard that referenced this issue Aug 19, 2022
@icburns
openboard-team#520 modify CHECKABILITY_CONTAINS_PERIOD logic to accou…
aa35d1d 
…nt for period only present in the last index (valid end of sentence).
icburns added a commit to icburns/openboard that referenced this issue Aug 19, 2022
@icburns
openboard-team#520 modify CHECKABILITY_CONTAINS_PERIOD logic to for c…
06de86d 
…apitalized words in suggestions.
@icburns icburns mentioned this issue Aug 19, 2022
Open
@gigisforza70 gigisforza70 mentioned this issue Jul 23, 2023
Closed
Helium314 referenced this issue in Helium314/HeliBoard Jul 26, 2023
@Helium314
fix red spell check for words ending in period on newer android versi…
a1cf043 
…ons, fixes #32

commit d9c7fd89548926eca24d22cbc784278df33eec47
Author: icburns <[email protected]>
Date:   Thu Aug 18 17:51:50 2022 -0700

    #520 modify CHECKABILITY_CONTAINS_PERIOD logic to for capitalized words in suggestions.

commit 630e03d88f0c3db9749fea228fd10a684c27732d
Author: icburns <[email protected]>
Date:   Thu Aug 18 17:47:23 2022 -0700

    #520 modify CHECKABILITY_CONTAINS_PERIOD logic to account for period only present in the last index (valid end of sentence).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@TheSkallywag @icburns @TheUglyOne @jnnkB @kafisc1 @EdgeCon