Add constructor option to allow reusing an axios instance #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #77
This adds the axiosInstance property to the constructor options. This PR also includes some refactoring and new tests.
I added this because some users want the option to reuse another axios instance. The change will make this library compatible with more libraries.
I added tests to ensure that none of the properties of the default request config are changed. This partially addresses npdev453's 2nd point in the issue thread. The baseUrl property is the only one that might be modified, but only when it's undefined.
The documentation needs to be updated to inform the user about potential problems with using the axiosInstance property. It looks like the documentation is separate from this repo, so I can't edit it, but I added the new property to the function documentation.