feat(ISSUE-685): constants support #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Overall I’m in favor of this change 👍🏻 . This seems to improve on existing behavior without breaking it. You’ll need to rebase off latest |
sadfsdfdsa
force-pushed
the
pr/685-issue-consts-enums-improving
branch
from
09a46d8 to
3cf31bb
Compare
|
@drwpow there is small diff to merge)) |
drwpow
approved these changes
Jan 11, 2022
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #685
Type: FEATURE
Tests: 100%
Affects: const/enums, all comments for const/enums
Now support const from yaml with type String/Number/Boolean:
Now support jsdoc comments for
@constant/@enum {type}, with nullable option also: