Fix custom fetch type #1587
Merged
Fix custom fetch type #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 086181d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JE-lee
force-pushed
the
custom-fetch-type
branch
from
5768af6 to
704bd78
Compare
|
This looks great! If the lint errors are fixed I’d be happy to merge |
JE-lee
force-pushed
the
custom-fetch-type
branch
from
704bd78 to
086181d
Compare
|
Sorry for the late response. Now it is done with no prettier problem. |
drwpow
approved these changes
Mar 29, 2024
|
Published in the latest version of openapi-fetch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix the custom fetch type.
The custom fetch type does not strictly adhere to the parameter type when calling.
https://github.com/drwpow/openapi-typescript/blob/4e06f86934e11f3dbc3aabee4b4e61dd62680782/packages/openapi-fetch/src/index.js#L101
It results in the wrong type checking when using the custom fetch.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)