Issue openam#291 OpenDJ version checks are inconsistent #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogis-miyamura
approved these changes
Nov 17, 2023
ogis-miyamura
deleted the
issues/openam/291-inconsistent-opendj-version-checks
branch
ogis-miyamura
restored the
issues/openam/291-inconsistent-opendj-version-checks
branch
ogis-miyamura
added a commit
that referenced
this pull request
Nov 17, 2023
ogis-miyamura
deleted the
issues/openam/291-inconsistent-opendj-version-checks
branch
|
Although I tried to reopen after merging, it turned out that there was no problem with the original content, so I decided to close both the pull request and branch with the original merged content. |
tsujiguchitky
added a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis
See openam-jp/openam#291
Solution
Ignore the buildRevision in OpenDJ version check
Testing
I performed the following tests with openam-jp/openam#292.
buildRevisionOpenDJ