Issue #206 Add options for Cookie SameSite attribute #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis
Chrome treats cookies that have no declared SameSite value as SameSite=Lax cookies.
As a result, OpenAM has some troubles (See #206).
Solution
Add the following settings.
{Cookie Name}={SameSite Value}
format.Also, add a properties file (SameSiteIncompatibleClient.properties) that excludes user agents, because there are incompatible browsers with SameSite.
Compatibility
This fix adds a parameter to
CookieUtils.addCookieToResponse()
. If using this method in a customized authentication module etc., rebuild it.Testing
SameSite=None
Regression testing