Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new option to generate subtitles by a specific number of words #1729

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Add new option to generate subtitles by a specific number of words #1729

merged 7 commits into from
Nov 6, 2023

Commits on Oct 22, 2023

  1. ADD parser for new argument --max_words_count

    @amolinasalazar
    amolinasalazar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    7f0dc9e View commit details
    Browse the repository at this point in the history

  2. ADD max_words_count in words_options 

    ADD warning for max_line_width compatibility
    @amolinasalazar
    amolinasalazar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    f11faf2 View commit details
    Browse the repository at this point in the history

  3. ADD logic for max_words_count

    @amolinasalazar
    amolinasalazar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    376acb2 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. rename to max_words_per_line

    @jongwook
    jongwook committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8e5200b View commit details
    Browse the repository at this point in the history

  2. make them kwargs

    @jongwook
    jongwook committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    541adb4 View commit details
    Browse the repository at this point in the history

  3. allow specifying file path by --model

    @jongwook
    jongwook committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    832c0e9 View commit details
    Browse the repository at this point in the history

  4. black formatting

    @jongwook
    jongwook committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    1775889 View commit details
    Browse the repository at this point in the history