-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssistantStream.accumulateDelta does not cover accumulating toolCall #771
Labels
bug
Something isn't working
Comments
1 task
A4F54B
pushed a commit
to A4F54B/openai-node
that referenced
this issue
May 22, 2024
1 task
A4F54B
pushed a commit
to A4F54B/openai-node
that referenced
this issue
Jun 25, 2024
Sorry for the bug here – we hope to take a look at the community PR soon. |
1 task
What is the state of this issue? it's been a couple months since the streaming api doesn't provide arguments on toolCallDone or toolCallCreated, however on toolCallDelta it provides the arguments. |
stainless-bot
pushed a commit
that referenced
this issue
Sep 3, 2024
stainless-app bot
pushed a commit
that referenced
this issue
Sep 3, 2024
* fix(accumulateDelta): AssistantStream accumulateDelta toolCall (#771) * minor style changes --------- Co-authored-by: A4F54B <[email protected]>
Really sorry for the delay here, this will be fixed in the next release #1028 |
Nice to hear that! Thanks @RobertCraigie |
stainless-app bot
pushed a commit
that referenced
this issue
Sep 3, 2024
* fix(accumulateDelta): AssistantStream accumulateDelta toolCall (#771) * minor style changes --------- Co-authored-by: A4F54B <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Confirm this is a Node library issue and not an underlying OpenAI API issue
Describe the bug
Say we have a delta like
You're missing functionality here:
https://github.com/openai/openai-node/blob/116e38aae33a2d7b88c27d783a95b41e56500600/src/lib/AssistantStream.ts#L686C1-L691C8
I recommend adding something like
To Reproduce
Any streamed tool call with arguments will do. Notice how the
argument
field is empty in the toolCall parameter from the event "toolCallDone"Code snippets
No response
OS
Linux
Node version
Node v20.11.1
Library version
openai v4.34.0
The text was updated successfully, but these errors were encountered: