Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts fail fast #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make scripts fail fast #29

wants to merge 3 commits into from

Conversation

fzyzcjy
Copy link

@fzyzcjy fzyzcjy commented Jan 23, 2023

When using it (incorrectly), I got something like

mv: rename ./_target/deps/mathlib/src/all.lean to ./_target/deps/minif2f/lean/src/all.lean: No such file or directory
./scripts/setup.sh: line 15: ./_target/deps/minif2f/lean/src/all.lean: No such file or directory
./scripts/setup.sh: line 16: ./_target/deps/minif2f/lean/src/all.lean: No such file or directory

However, the script continues running and thus it is easy for users not to realize this problem. Thus, to follow the best practices of shell scripting, I add the flags to make it fail fast.

@fzyzcjy fzyzcjy marked this pull request as ready for review January 23, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant